IOS-7652 Load images during onboarding #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
commented
Aug 24, 2024
| .store(in: &bag) | ||
| } | ||
|
|
||
| override func loadImage(supportsOnlineImage: Bool, cardId: String?, cardPublicKey: Data?) { |
There was a problem hiding this comment.
Честно говоря не сильно понятно, зачем эта перегрузка, может добавляли, когда был дев режим для тестов. Проперти secondImage в целом не юзалось
There was a problem hiding this comment.
не помню точно, но скорее всего это для первого экрана онбординга, где 2 карточки было, чтобы анимированный переход делать от welcome к онбордингу или что-то такое)
tureck1y
commented
Aug 24, 2024
| @@ -329,19 +329,6 @@ class WalletOnboardingViewModel: OnboardingViewModel<WalletOnboardingStep, Onboa | |||
| subscribeToScreenshots() | |||
| } | |||
|
|
|||
| private func loadImageForRestoredbackup(cardId: String, cardPublicKey: Data) { | |||
There was a problem hiding this comment.
не использовалось
Balashov152
previously approved these changes
Aug 27, 2024
Andoran90
previously approved these changes
Aug 27, 2024
| .store(in: &bag) | ||
| } | ||
|
|
||
| override func loadImage(supportsOnlineImage: Bool, cardId: String?, cardPublicKey: Data?) { |
There was a problem hiding this comment.
не помню точно, но скорее всего это для первого экрана онбординга, где 2 карточки было, чтобы анимированный переход делать от welcome к онбордингу или что-то такое)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Теперь будут загружаться картинки каждой из карт во время онбординга
TODO: Bump SDK